[IFRT] Allow kReuseInput in RemapArrays if the number of input arrays is 1 #67763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_634485955
branch
8 times, most recently
from
6f91735
to
f5fc884
Compare
… is 1 `xla::ifrt::Client::RemapArrays()` allows `kReuseInput` for projection (view). Previously, it expected the number of input arrays and output arrays is both 1. This restriction has been relaxed to expecting only the number of input arrays to be 1 because each of output arrays can be considered a projection of the input arrays. In theory, the user could run N `RemapArrays()` for 1:1 remapping to get 1:N remapping anyway to bypass the previous restriction, making the restriction not effective. PiperOrigin-RevId: 634818012
copybara-service
bot
force-pushed
the
exported_pr_634485955
branch
from
f5fc884
to
e116891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IFRT] Allow kReuseInput in RemapArrays if the number of input arrays is 1
xla::ifrt::Client::RemapArrays()allowskReuseInputfor projection (view).Previously, it expected the number of input arrays and output arrays is both 1.
This restriction has been relaxed to expecting only the number of input arrays
to be 1 because each of output arrays can be considered a projection of the
input arrays. In theory, the user could run N
RemapArrays()for 1:1 remappingto get 1:N remapping anyway to bypass the previous restriction, making the
restriction not effective.