-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
units: also swap ordering of systemd-exit.service vs exit.target and friends #32895
base: main
Are you sure you want to change the base?
Conversation
Important An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
Is not |
systemd-journald.service should be running at the very last stage of shutdown process. To make journald stopped only on soft-reboot, it is necessary to make soft-reboot.target is a usable synchronization point.
|
softreboot is new enough and there were actual issues, but I don't think we should change these ones after RC2, unless there's a specific bug that is being solved. Could you please split the manpage change in a separate PR? |
Okay. But I'd like to wait for @poettering's comment about the swap of the ordering done in #32880. |
So yeah, I think this should be exclusive to soft-reboot, which is realistically more similar to switch-root rather than normal shutdown. If one day an actual issue pops up with the current ordering, we can always revisit things. All normal services should conflict with |
Prompted by systemd#32895 Rather than ordering with each power operation targets, ordering against shutdown.target which is a valid synchronization point. This has no effect if soft-reboot is being performed.
I opened #32897, to ensure that units that should survive soft-reboot are stopped at correct spot on normal shutdown. It shouldn't be necessary to swap the orders like this PR does. |
Prompted by #32895 Rather than ordering with each power operation targets, ordering against shutdown.target which is a valid synchronization point. This has no effect if soft-reboot is being performed.
…friends Otherwise, the targets cannot be used as a synchronization point. Follow-up for 4263d76.
Maybe. But not sure. People may want to do something different on e.g. reboot. |
(need to include reverts for reverts in #32975) |
Follow-up for 4263d76 (#32880).
Otherwise, the targets cannot be used as a synchronization point.