-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ya pack
pretty prints plugin config
#1020
ya pack
pretty prints plugin config
#1020
Conversation
This allows using plugins that end in ".yazi"
This way the user can easily diagnose the situation without knowing the internals of the yazi plugin system.
A pretty printed configuration file makes it easier to see the differences between two versions of the configuration file.
ef3ef24
to
58b6e75
Compare
Oops, looks like plugins now get added as duplicates.. Let me fix that! |
Ok, duplicate plugin addition has now been fixed! |
Hi, thanks for the PR! Using
Therefore, I'd prefer to keep the current behavior. Curious your thoughts! |
Oh, I see. I think this is about the difference between a recipe file and a lock file. A recipe file:
A lock file:
I think what I have done here is treat I think it comes down to preference, and what you think is best should be followed. |
Example of a pretty printed configuration:
This is how it would look if not pretty printed:
Error reporting (in case the configuration is invalid) now looks like this:
Note: this change rebuilds the configuration parsing by switching the
toml_edit
crate totoml
. This means the plugin system is now declarative instead of procedural.I find this significantly simplifies the implementation, but let me know what you think!