Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shutdown of tasks #3977

Closed
wants to merge 4 commits into from

Conversation

phughk
Copy link
Contributor

@phughk phughk commented May 2, 2024

Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.

What is the motivation?

Flume channel into_stream does not terminate if a channel is dropped.
https://docs.rs/flume/latest/flume/struct.Receiver.html#method.stream

What does this change do?

Fix termination

What is your testing strategy?

RUST_LOG=trace cargo test --package surrealdb --no-default-features --features kv-mem api::engine::tasks::test::tasks_complete_channel_closed -- --nocapture

Is this related to any issues?

Potentially tied to #3906 , but not the main cause

Does this change need documentation?

Have you read the Contributing Guidelines?

@phughk
Copy link
Contributor Author

phughk commented Jun 4, 2024

Closed because I am not working on this

@phughk phughk closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant