Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add integer output adapter #29

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

AndrewBKang
Copy link
Contributor

No description provided.

@AndrewBKang
Copy link
Contributor Author

#16

@swerner
Copy link
Contributor

swerner commented May 2, 2024

For these new output adapters, let's also make sure to create a new example in the examples directory that uses it along with the specs for the main 3 providers like in here: https://github.com/sublayerapp/sublayer/blob/main/spec/generators/examples/code_from_description_generator_spec.rb

I expect that we're going to be changing up the format_properties method in the providers a bunch so want to make sure that will still work across all these adapters.

Also, kind of thinking we may not need to assert on the exact contents, since that will probably change any time we re-generate the VCR cassettes....maybe there's a way to verify that the contents of the generate call actually exist and are roughly correct? Like for this integer one, that the result is actually a number, but the exact number doesn't matter for testing purposes you know?

Base automatically changed from 0.1 to main May 16, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants