Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use OperatingSystem.IsXyz instead of RuntimeInformation.IsOSPlatform #2247

Merged
merged 1 commit into from
May 18, 2024

Conversation

Jklawreszuk
Copy link
Collaborator

PR Details

Description

PR replaces all occurrences of IsOSPlatform in favor of the more modern OperatingSystem.IsXyz available in NET5+.

Related Issue

None

Motivation and Context

The main motivation is less preprocessor directives and modernizing the code. In theory, methods should be faster because they are constants

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Jklawreszuk Jklawreszuk changed the title Use OperatingSystem.IsXyz instead of RuntimeInformation.IsOSPlatform feat: Use OperatingSystem.IsXyz instead of RuntimeInformation.IsOSPlatform May 15, 2024
@Eideren Eideren changed the title feat: Use OperatingSystem.IsXyz instead of RuntimeInformation.IsOSPlatform fix: Use OperatingSystem.IsXyz instead of RuntimeInformation.IsOSPlatform May 18, 2024
@Eideren
Copy link
Collaborator

Eideren commented May 18, 2024

Thanks !

@Eideren Eideren merged commit a1d1784 into stride3d:master May 18, 2024
13 checks passed
@Jklawreszuk Jklawreszuk deleted the runtimeinfo-to-operatingsystem branch May 18, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants