Fix some flaky e2e tests #8688
Merged
Fix some flaky e2e tests #8688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raethlein
added
type:enhancement
kajarenc
reviewed
May 16, 2024
| dialog.locator("div", has_text="Large-width Dialog").click() | ||
| submit_button = dialog.get_by_test_id("stButton") | ||
| expect(submit_button).to_be_visible() | ||
| submit_button.get_by_test_id("baseButton-secondary").hover() |
There was a problem hiding this comment.
submit_button.hover() doesn't work, and we need a more narrow locator here?
There was a problem hiding this comment.
yep, I tried the other one first but apparently the effect happens on the button element itself!
kajarenc
approved these changes
May 16, 2024
raethlein
force-pushed
the
tests/fix-flaky-dialog-tests
branch
from
462b088
to
1318724
Compare
## Describe your changes Similar to the dataframe selection tests, we want to test chart selections with callbacks and inside forms or fragments explicitly. Also fix two issues with the dataframe selection e2e tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
For some tests its difficult to reproduce them, so this is a best-effort change based on patterns we have seen in the past.
st_dialog_test.py:
st_altair_chart_basic_select_test:
test_point_bar_chart_displays_selection_textst_date_input_test:
custom_components/popular_components:
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.