Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router: Update utils.js to support older environments #27176

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

GeorgeTaveras1231
Copy link

…kage exports

This import path is broken. It is correct in the package.json

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

…kage exports

This import path is broken. It is correct in the package.json
@shilman shilman changed the title Update utils.js to support older environments that do not support pac… Router: Update utils.js to support older environments May 25, 2024
@shilman shilman added maintenance User-facing maintenance tasks core labels May 25, 2024
@shilman shilman requested a review from ndelangen May 25, 2024 14:14
Copy link

nx-cloud bot commented May 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4e2dde7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic
Copy link
Contributor

Hi @GeorgeTaveras1231

Thank you for the PR.

Can you provide a reproduction of the issue and explain in which specific environments the issue occurs?

@GeorgeTaveras1231
Copy link
Author

GeorgeTaveras1231 commented May 31, 2024

@valentinpalkovic I will follow up with repro when I have more time, but for now I'll just ask a clarifying question and share the cases that are top of mind.

The question is, is. The './utils.js' file meant to be a mirror of the ./utils export in the package.json? I jumped to this conclusion while navigating the code and trying to resolve another problem I had 😅. My assumption was based on this, and my knowledge of the ecosystems that support package exports. From my understanding older versions of node (<12), webpack (<=4), jest (<28), TypeScript (<=4) dont support package exports, and would fallback to using this file when importing the utils entry of this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal core maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants