Overload setCurrentPosition() to allow disabling the scroll animation #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's another PR for when you get a chance to poke at this library some more. I have a use case that benefits from the setCurrentPosition() method that was added in 1.0.0, but this use case also looks nicer if there's no animation when the viewer changes the image being displayed. (The image is changed when returning from an activity that was launched while viewing an image.) In case it's useful to others, here's my patch to add an optional second argument to setCurrentPosition which controls the smooth scroll animation (
true=animation,false=no animation). The one-argument form continues to use the animation, so there's no change to existing code using the library. The value of that second argument is passed through to the two-argument form of setCurrentItem in the androidx ViewPager that MultiTouchViewPager extends.