Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add constants/float32/phi #2249

Merged
merged 1 commit into from
May 18, 2024

Conversation

gunjjoshi
Copy link
Contributor

@gunjjoshi gunjjoshi commented May 18, 2024

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Float64 and Float32 values for reference:

In [2]: float64ToFloat32(1.618033988749895)
Out[2]: 1.6180340051651

In [3]: float64ToFloat32( 1.61803398874989484820458683436563811772030917980576286213544862 )
Out[3]: 1.6180340051651

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers
@Planeshifter

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Planeshifter Planeshifter merged commit 6853d27 into stdlib-js:develop May 18, 2024
7 checks passed
@gunjjoshi gunjjoshi deleted the float32-phi branch May 19, 2024 03:50
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants