-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gifs, Update Stars and Videos #21
base: master
Are you sure you want to change the base?
Conversation
c69d53a
to
31c965e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new feature, so in the future please use feat/<feat_name>
branch for this kind of PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you replace using hard coded integers for sorting with enums? It would be a much more elegant way for this kind of job.
This should not be all in one PR. Please, in the future, use I will merge it after all comments are resolved for now. |
Added:
Gifs
with methodsgetGifs
andgetGif
, that similar likeVideos
methods. Sorting parameters:sort_by
andperiod
Updated:
Stars
:a) Added
getStar
method, that give more detail information. Also addedfull_data
argument togetStars
b) Added sorting parameters:
period
andp_type
Videos
: Added sorting parameters:period
andregion