Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logging to YAML Properties Resolving(RouterFunctionHolderFactory) #3396

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Logging to YAML Properties Resolving(RouterFunctionHolderFactory) #3396

wants to merge 2 commits into from

Conversation

jivebreaddev
Copy link

@jivebreaddev jivebreaddev commented May 16, 2024 •
edited

Hi,

Description

  1. In a raised issue(Adding circuitBreaker filter in mvc throws IllegalArgumentException #3327), given yaml file to configure CircuitBreakerConfig seems to fail and produce an error below:
    image
  • given a Configuration Bean, the properties were bound successfully and CircuitBreaker was created successfully.

image

  • in a situation where yaml file was passed on, CircuitBreaker failed to create.

image

  1. Noticing yaml properties binding failures was painful without debugging statements.

image

Such Logging will provide a mean to evaluate failure in binding yaml properties.

Helps debugging #3327

@Jivebread
findOperation method will not show any useful information when bindin…
bc75951 
…g yaml properties to each class instances.

Such Logging will provide a mean to evaluate failure in binding yaml properties.

spring-cloud#3327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting-for-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jivebreaddev @spring-cloud-issues @Jivebread