This repository has been archived by the owner on Mar 31, 2022. It is now read-only.
Fix for #292: Skip plugin execution when a Dockerfile is not present #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t present in a module With this fix, the plugin execution is skipped when a project/module did not have a default Dockerfile and the config parameter failedOnMissingDockerfile is set to false (default to true)
|
Is there any chance this change can be merged for the benefit of multimodule projects? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new config key
dockerfile.failedOnMissingDockerfilehas been added for this fix.More info on #292