Add relative path fix to git-hub-browse #2087
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cypher1
commented
May 8, 2024
| @@ -42,7 +44,8 @@ if [[ "$reference" == 'HEAD' ]]; then | |||
| reference="$(command git rev-parse HEAD 2> /dev/null)" | |||
| fi | |||
|
|
|||
| file="$3" | |||
| file="${3:-$(pwd)}" | |||
| file="$(command realpath "$file" | sed "s|^$root||")" | |||
There was a problem hiding this comment.
I'd love suggestions on the 'proper' way to do this in zsh as I'm not experienced with it and shellcheck doesn't zsh yet.
There was a problem hiding this comment.
I think file="${${file:P}#$root}" will do the work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes path handling for the command
git-hub-browseto use relative paths.This enables opening the current working directory or a file in a directory without manually specifying the file path relative to the root.
Proposed Changes
realpathto get the full path of the file or directorygit rev-parse --show-toplevelto get the root directorysedto remove the root from the full path, making it root relative.pwd(current working directory) as the default path, rather than ""