Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Clean up service replicas when CONTROLLER_FAILED happens #3470

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Michaelvll
Copy link
Collaborator

When the controller failed, it is likely that no controller job will be in charge of terminating the replicas, which will cause resource leakage.

We now automatically remove the replicas that were managed by the CONTROLLER_FAILED controller.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll changed the base branch from update-job-status to master April 23, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant