Formatting #369

Kim-Dewelski · 2023-12-17T00:21:20Z

Added a formatting script to format the project, and crated a clang-format script using the LLVM formatting style. If we want another style it is a simple fix!

…plicitly

skylersaleh · 2023-12-17T00:24:58Z

src/main.c

 #define CIMGUI_DEFINE_ENUMS_AND_STRUCTS
+#include "IconsForkAwesome.h"


Includes should not be moved past defines.

skylersaleh · 2023-12-17T00:25:56Z

src/main.c


 #define SE_MAX_CONTROL_POINTS 32
-#define SE_REGION_NAME                 0


We need to make it not break aligned numbers like this.

right I will try to see if I can make it do that

skylersaleh · 2023-12-17T00:27:37Z

src/main.c

-  uint32_t version_code; 
-  uint8_t palettes[5*4];
+  uint32_t version_code;
+  uint8_t palettes[5 * 4];


and / should not be wrapped in spaces (but + and - should be wrapped in spaces) to improve readability.

uhm ok sounds like a good idea

clang format does unfortunately not seem to support this (?)
is this a deal breaker? It seems to want to have spaces between most operators.

skylersaleh · 2023-12-17T00:29:00Z

src/main.c

-static bool se_draw_theme_region_tint(int region, float x, float y, float w, float h,uint32_t tint);
-static bool se_draw_theme_region_tint_partial(int region, float x, float y, float w, float h, float w_ratio, float h_ratio, uint32_t tint);
-static const char* se_get_pref_path(){
+static bool se_load_theme_from_file(const char *filename);


Don't auto word wrap long lines.

skylersaleh · 2023-12-17T00:31:41Z

src/main.c

  dpi_scale = sapp_dpi_scale();
-  if(dpi_scale<=0)dpi_scale=1.;
-  dpi_scale*=1.10;
+  if (dpi_scale <= 0)


if/while should not have spaces between "("

if statements without {} should always be on the same line as their statement (it prevents bugs)

do we always want {} to create a new line?

No, leave it up to the programmer to put the new lines if they want it.

skylersaleh · 2023-12-17T00:32:07Z

src/main.c

  const utf8proc_uint8_t *str = (const utf8proc_uint8_t *)input_string;
-  while(str[0]){
+  while (str[0]) {


no space between ) and {

doesn't seem to be an option sadly

skylersaleh · 2023-12-17T00:32:56Z

src/main.c

+    str += size;
+    if (codepoint_ref > SE_MAX_UNICODE_CODE_POINT)
+      continue;
+    ;


Where did this extra semicolon come from?

skylersaleh · 2023-12-17T00:34:45Z

src/main.c

-static inline const char* se_localize_and_cache(const char* input_str){
-  const char * localized_string = se_localize(input_str);
+static inline const char *se_localize_and_cache(const char *input_str) {
+  const char *localized_string = se_localize(input_str);


Can you configure the formatting to not touch the location of * in variable names?

dunno but I will try

No sadly, it does not seem like it, but we can tell it to put pointers to the left, right or in the middle. Maybe I simply missed it in the docs because it does feel like it should be an option but it is not.

Does it still format them even if you don't have a PointerAlignment field?

I can look into it.

Nope it defaults to right alignment if I do that.

skylersaleh · 2023-12-17T00:37:35Z

src/main.c

-const char* se_keycode_to_string(int keycode){
-  switch(keycode){
-    default:           return "Unknown";
-    case SAPP_KEYCODE_SPACE:         return "SPACE";


It needs to not break up these case labels and the returns onto separate lines.
They are laid out like this to allow block edits.

skylersaleh · 2023-12-17T00:39:59Z

src/gba_bios.h

Don't format this file

skylersaleh · 2023-12-17T00:40:16Z

src/nds_rom_database.h

Don't format this file

skylersaleh · 2023-12-17T00:40:44Z

src/lcd_shaders.h

Don't format this file

skylersaleh · 2023-12-17T02:19:47Z

src/main.c

-  "Toggle Full Screen"
-};
+const static char *se_keybind_names[SE_NUM_KEYBINDS] = {
+    "A",


This should only be 2 spaces

we want a tab width of 2 spaces?

I will fix that

skylersaleh · 2023-12-17T02:21:14Z

src/main.c

+  // Utilize a watchdog channel to detect if the audio context has encountered an error
+  // and restart it if a problem occurred.
+  int                     audio_watchdog_timer;
+  int                     audio_watchdog_triggered;


Spacing here is a bit long

The spacing is long in order to have alignment, we could add newlines between the lines to alleviate that

things like this may happen a bit everywhere though so declarations are aligned, it is sadly impossible as far as I can see to give it a sort of threshold.

…matter

Kim-Dewelski added 7 commits December 17, 2023 00:20

added clangd compile json by default

ba5d4af

removed clang-tidy warning about suspicious string literal

54766ec

removed clang warnings about implicit float conversion by doing it ex…

37fcd6b

…plicitly

ignore tab input focus shift for sliders

2773395

added clang format file (with llvm style) and a formatting bash script

53f0728

added whitespace sensitive macros

aee3450

formatted files

371a629

skylersaleh reviewed Dec 17, 2023

View reviewed changes

Merge remote-tracking branch 'other/dev' into formatting

75357c7

skylersaleh reviewed Dec 17, 2023

View reviewed changes

src/main.c

str += size;

if (codepoint_ref > SE_MAX_UNICODE_CODE_POINT)

continue;

;

Copy link

Owner

skylersaleh Dec 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this extra semicolon come from?

skylersaleh reviewed Dec 17, 2023

View reviewed changes

src/gba_bios.h Outdated

Copy link

Owner

skylersaleh Dec 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't format this file

skylersaleh reviewed Dec 17, 2023

View reviewed changes

src/nds_rom_database.h Outdated

Copy link

Owner

skylersaleh Dec 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't format this file

skylersaleh reviewed Dec 17, 2023

View reviewed changes

src/lcd_shaders.h Outdated

Copy link

Owner

skylersaleh Dec 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't format this file

Kim-Dewelski added 4 commits December 17, 2023 02:12

reset formatting

9479b83

added changes to format file

68a9afa

ignoring formatting for arm table definition

c593fa4

ignoring formatting for lookup table

859c1e1

Kim-Dewelski force-pushed the formatting branch from 184ddd6 to 859c1e1 Compare December 17, 2023 01:46

Kim-Dewelski added 3 commits December 17, 2023 03:09

ignore formatting for nds tables

4679d8b

ignore tables in gb/gba headers

5ccabe0

reformatted now ignoring tables

81fb1ed

Kim-Dewelski force-pushed the formatting branch from 242f3d9 to 81fb1ed Compare December 17, 2023 02:12

skylersaleh reviewed Dec 17, 2023

View reviewed changes

Kim-Dewelski added 5 commits December 17, 2023 03:24

format checker script

1ee03cd

set tab width to 2

eaa0866

added spacing between items in main.c in order to not confuse the for…

db13bee

…matter

added spacing width of 2

12fafd0

reformatted

0b70c63

Kim-Dewelski force-pushed the formatting branch from a3c27a8 to 0b70c63 Compare December 17, 2023 02:58

Kim-Dewelski and others added 4 commits December 17, 2023 04:03

removed using tabs

f40a71b

【Format】Tweaks to clang-format formatting

4263de6

【NDS】Fix up NDS formatting

4e7cbf9

[GBA] Formatting fixes

307e0d7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Formatting #369

Formatting #369

Kim-Dewelski commented Dec 17, 2023

skylersaleh Dec 17, 2023

skylersaleh Dec 17, 2023

Kim-Dewelski Dec 17, 2023

skylersaleh Dec 17, 2023

Kim-Dewelski Dec 17, 2023

Kim-Dewelski Dec 17, 2023

skylersaleh Dec 17, 2023

skylersaleh Dec 17, 2023

Kim-Dewelski Dec 17, 2023

skylersaleh Dec 17, 2023

skylersaleh Dec 17, 2023

Kim-Dewelski Dec 17, 2023

skylersaleh Dec 17, 2023

skylersaleh Dec 17, 2023

Kim-Dewelski Dec 17, 2023

Kim-Dewelski Dec 17, 2023

OFFTKP Dec 17, 2023

Kim-Dewelski Dec 17, 2023

Kim-Dewelski Dec 17, 2023

skylersaleh Dec 17, 2023

skylersaleh Dec 17, 2023

skylersaleh Dec 17, 2023

skylersaleh Dec 17, 2023

skylersaleh Dec 17, 2023

Kim-Dewelski Dec 17, 2023

Kim-Dewelski Dec 17, 2023

skylersaleh Dec 17, 2023

Kim-Dewelski Dec 17, 2023 •

edited

Kim-Dewelski Dec 17, 2023

		#define CIMGUI_DEFINE_ENUMS_AND_STRUCTS
		#include "IconsForkAwesome.h"

Formatting #369

Are you sure you want to change the base?

Formatting #369

Conversation

Kim-Dewelski commented Dec 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kim-Dewelski Dec 17, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kim-Dewelski Dec 17, 2023 •

edited