Retro Achievements

[OFFTKP]

Ongoing PR for retro achievements integration

[OFFTKP]

Let me know what you think of the structure. Basically you'd login from the UI and call ra_login_credentials (and then it would auto log in on startup using ra_login_token). If this is fine I need a login UI and a way to save/load the token from the platform specific save directory.

[skylersaleh]

Overall structure looks reasonable to me. Make sure to #ifdef Retro Achievements support and make it configurable from CMAKE as some platforms will not be able to communicate with the Retro Achievements server (ie. Web)

[OFFTKP]

Does the async image loading/caching function look good to you? Basically you call se_ra_get_image with the url and a callback after it's downloaded/loaded. See se_ra_get_image(ra_info.game_title, url, se_ra_load_game_image_callback, NULL); for example loads the game image. Later we also need to load achievement images but I wanna make sure you like this function first.

[skylersaleh]

A couple of bugs I've noticed so far:

• Auto Login after exit doesn't seem to work properly.
• Achievement list/game is not getting loaded when a user logs in after a game is already loaded.
• Achievement lists don't seem to be cleared when launching a game that does not have achievements after a game that had achievements was loaded

Could you root the above out and fix them? I'll commit some other changes for the async image loading. I want to redo how this is handled a bit so that code can be shared with some of the other UI work I want to do later and hopefully reduce the surface area for potential bugs.

[OFFTKP]

For the last one, can you tell me a game that doesn't have achievements so I can reproduce?

[skylersaleh]

For the last one, can you tell me a game that doesn't have achievements so I can reproduce?

You can just use any GBA/GB test ROM (ie. mGBA suite)

[OFFTKP]

With the last patch all three bugs should be fixed

[OFFTKP]

Fixed merge conflict and rebased with upstream dev

[OFFTKP]

Removed std::future/std::async stuff, just running http requests on detached threads
Instead of waiting on the requests, now just pushing the callback to a vector and checking that from the main thread. This means the image creating/game loading callbacks should only be called after calling ra_run_pending_callbacks from the main thread, so the lock_mutex stuff should not be needed, as ra_info editing would happen on the same thread.

The recursive_mutex.h stuff was ugly anyway so I'm happier with this. Let me know if the previous crashes still happen.

[OFFTKP]

needs some more chasing, there are still some bugs