-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore old functionaliy for some Quill toolbar classes #1633
base: master
Are you sure you want to change the base?
Conversation
If we solve the conflicts and merge this, does that fix your issue? |
I restored only buttons which I used but there are other ones which are not fixed. So if button in web looks like before modifications it should looks like so after modifications but not like I tested example app so you may read #1628 (comment) for results. |
Description
Today I have again spent time to make my project looks as it must. I do not do anything critical just restore the funcitonality of some toolbar classes as they were. You may consider this PR as a starting point for all other buttons which I didn't change. The only thing is required is change call of
QuillToolbarIconButton
inbuild
methods of embed buttons, search button and maybe others. You may see what I did. I also restored oldQuillToolbarSelectAlignmentButton
and save it asQuillToolbarSelectTextAlignmentButton
.I need this modifications to make my project compiled and continue working. You may merge this PR or use it for understanding how to make package backward compatible. It will take less effors.
Related Issues
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).