-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade jni to 0.21.1 #32216
Upgrade jni to 0.21.1 #32216
Conversation
Here's my attempt as fixing these issues: 41bde52 I'm stuck fighting with the borrow checker. It's unclear how to create a JValue from a Rust string and pass it to |
With these changes on top of @mrobinson 's commit, I was able to get the android build to succeed and do a test run on my device. The major change is the addition of the |
JNI methods in `jniapi` now have explicit lifetime annotations to adapt it to the new `jni` version. Co-authored-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com> Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
@mrobinson I've rebased and pushed all the changes in a single commit. Please review whenever you get a chance. |
Nice! |
Split from #31278.
Co-authored-by: Martin Robinson mrobinson@igalia.com
Co-authored-by: Mukilan Thiyagarajan mukilan@igalia.com
./mach build -d
does not report any errors./mach test-tidy
does not report any errors