Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up turbo #757

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

chore: set up turbo #757

wants to merge 11 commits into from

Conversation

sripwoud
Copy link
Contributor

@sripwoud sripwoud commented Apr 29, 2024

WIP

Description

Set up turbo to run tasks and cache their results for operations related to:

  • buildings apps and packages
  • linting
  • formatting
  • testing
Before After
tasks dependencies none, needs to manually run necessary build tasks before executing linting or testing tasks defined, turbo will automatically run and wait for build tasks to complete before linting or testing
speed (ex: building then testing libraries) pic-selected-240502-1553-29 pic-selected-240502-1554-48

Related Issue(s)

Closes #745

Other information

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sripwoud sripwoud added the devops 🔧 Operations management and dev tools label Apr 29, 2024
@sripwoud sripwoud self-assigned this Apr 29, 2024
Copy link

openzeppelin-code bot commented Apr 29, 2024

chore: set up turbo

Generated at commit: dd07a851524c09208726945121180c119b255ded

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
0
0
4
16
20
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@sripwoud sripwoud marked this pull request as ready for review May 2, 2024 13:58
@sripwoud
Copy link
Contributor Author

sripwoud commented May 2, 2024

I am not sure whether the failing test is related to my PR?
https://github.com/semaphore-protocol/semaphore/actions/runs/8925027515/job/24512736232#step:7:426
Looks like a matchtick install/config error no?

@sripwoud sripwoud requested review from cedoor and vplasencia May 2, 2024 14:00
@cedoor
Copy link
Member

cedoor commented May 7, 2024

I am not sure whether the failing test is related to my PR? https://github.com/semaphore-protocol/semaphore/actions/runs/8925027515/job/24512736232#step:7:426 Looks like a matchtick install/config error no?

It looks like it's trying to run tests on the Semaphore subgraph without running yarn codegen first, which should generate the subgraph.yaml file.

Maybe yarn style is not enough, it also needs to yarn build:subgraph somewhere.

@sripwoud
Copy link
Contributor Author

sripwoud commented May 8, 2024

Fixed in last commit.
We should decide what to merge first though: #765 or #757
I think I'd prefer merging #765 first and then reworking #757

@cedoor
Copy link
Member

cedoor commented May 8, 2024

Fixed in last commit. We should decide what to merge first though: #765 or #757 I think I'd prefer merging #765 first and then reworking #757

Merged!

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @sripwoud

@sripwoud sripwoud marked this pull request as draft May 13, 2024 16:38
@sripwoud
Copy link
Contributor Author

sripwoud commented May 13, 2024

re error when running subgraph test script:
I don't think it is up to semaphore to document this or prevent it from happenning. Just want to share in case it comes up again for someone.
I had 2 errors related to the installation of https://github.com/graphprotocol/graph-tooling/tree/main/packages/cli on linux environment (arch) due to missing lower level libraries:

semaphore/node_modules/binary-install-raw/bin/0.5.0/binary-linux-20: error while loading shared libraries: libpq.so.5: cannot open shared object file: No such file or directory

solved by installing postgresql-libs

and then

semaphore/node_modules/binary-install-raw/bin/0.5.0/binary-linux-20: error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory

solved by installing openssl-1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops 🔧 Operations management and dev tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Turbo
3 participants