Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.cfg: Add PEP 561 py.typed marker #4391

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

cdleonard
Copy link
Contributor

This is required in order to use mypy with scapy annotations in a dependent project. Otherwise you get messages like these:

error: Skipping analyzing "scapy.packet": module is installed, but missing library stubs or py.typed marker [import-untyped]

This is required in order to use mypy with scapy annotations in a
dependent project. Otherwise you get messages like these:

error: Skipping analyzing "scapy.packet": module is installed, but missing library stubs or py.typed marker  [import-untyped]
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.56%. Comparing base (8461c2e) to head (991a7b8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4391      +/-   ##
==========================================
- Coverage   81.56%   81.56%   -0.01%     
==========================================
  Files         352      352              
  Lines       83897    83897              
==========================================
- Hits        68431    68429       -2     
- Misses      15466    15468       +2     

see 3 files with indirect coverage changes

Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR !

I must say I didn't know about PEP561.... the fact that we need this is very dumb.

@gpotter2 gpotter2 merged commit 4bc73ed into secdev:master May 22, 2024
22 of 23 checks passed
@cdleonard cdleonard deleted the pytyped branch May 27, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants