pkg: add an underlying package hostpool to manage general host operation #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 18.39% // Head: 18.39% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1713 +/- ##
=======================================
Coverage 18.39% 18.39%
=======================================
Files 66 66
Lines 5359 5359
=======================================
Hits 986 986
Misses 4247 4247
Partials 126 126 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
allencloud
force-pushed
the
add-hostpool-pkg
branch
3 times, most recently
from
ef7f80c
to
dd591b0
Compare
Signed-off-by: Allen Sun <shlallen1990@gmail.com>
allencloud
force-pushed
the
add-hostpool-pkg
branch
from
dd591b0
to
dcb1aa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun shlallen1990@gmail.com
Describe what this PR does / why we need it
This pull request added an underlying package hostpool to manage general host operation. This could be regarded as the infradriver in @VinceCui 's refactoring pull request #1621.
While this pull request encapsulates all host into an Object, and all node operation could be a sub operation of this HostPool and Host sub functions.
This pull request just add a package and does no invasion to the current code system.
In the next days, I would do further investigation to sealer execution procedure, to find out what kinds of operation function could be add to the HostPool package. Further investigation to sealer execution procedure would be related to the background of issue #1651 .
Does this pull request fix one issue?
none
Describe how you did it
none
Describe how to verify it
none
Special notes for reviews
none