Small code fixes and some textual edits #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code needs some minor changes to compile if copy-pasted from the text.
I assumed that I could use the following to both slice and insert code at the same time, if that doesn't work there is a problem with my commit:
~~~~ {.haskell slice="src/parsers/parsec.hs" lower=5 upper=15}
<code here>
~~~~
I was (/am) a bit confused by the output of parse being a list of tuples while everywhere we seem to deal with a single tuple or the empty list. I hypothesized why this would be and added that to the text but I'm not sure it's correct.
In a couple of places the code seems clipped, often a line at the beginning is missing which seems like it should be there. However, the numbers given in the slice do seem to correspond to the numbers I see when I look up the source. I'm not sure what's going wrong here (no changes made on this).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code needs some minor changes to compile if copy-pasted from the text.
I assumed that I could use the following to both slice and insert code at the same time, if that doesn't work there is a problem with my commit:
I was (/am) a bit confused by the output of parse being a list of tuples while everywhere we seem to deal with a list of a single tuple or the empty list. I hypothesized why this would be and added that to the text but I'm not sure it's correct.
In a couple of places the code seems clipped, often a line at the beginning is missing which seems like it should be there. However, the numbers given in the slice do seem to correspond to the numbers I see when I look up the source. I'm not sure what's going wrong here (no changes made on this).