locator: Remove unused lshift-operator for topology

[xemul]

No description provided.

[tchaikov]

lgtm

[nyh]

Again, I'm curious about the motivation - is it because we have a better fmt version so we don't need this one?

Or we don't have anything better but it's simply unused so you want to delete it?

I think it makes sense to have output functions for most if not all types, even if you're not using them in any existing code. I don't think unused printing functions are bad. Leaving unused printing functions means that if one day in the future I want to debug something, I can print out random objects the code is holding, and hopefully the code will have an operator<< and/or fmt implemented for it and it will work.

[xemul]

Again, I'm curious about the motivation - is it because we have a better fmt version so we don't need this one?
Or we don't have anything better but it's simply unused so you want to delete it?

The latter, no code prints topology currently.

I think it makes sense to have output functions for most if not all types, even if you're not using them in any existing code. I don't think unused printing functions are bad. Leaving unused printing functions means that if one day in the future I want to debug something, I can print out random objects the code is holding, and hopefully the code will have an operator<< and/or fmt implemented for it and it will work.

AFAIU logging an object with defined operator<< won't work on modern fmtlib as the "fallback formatter" is deprecated since recently. For types that are printed we have formatters, that work with fmt and logging and we keep operator<<'s for types that are still printed using legacy ostream.

[scylladb-promoter]

🟢 CI State: SUCCESS

✅ - Build
✅ - Container Test
✅ - Unit Tests
✅ - dtest with topology changes
✅ - dtest

Build Details:

• Duration: 3 hr 56 min
• Builder: spider7.cloudius-systems.com