feat: Adding anime specific Sonarr/Radarr instance support

[thempc]

re #2876

Description

This change adds the option to set a Sonarr or Radarr service as an Anime specific instance.
Adding this helps a number of people who are runnign two instances for separating anime and regular tv shows.

Screenshot (if UI-related)

Adding or Editing services:

To-Dos

• Successful build yarn build
• Translation keys yarn i18n:extract
• Database migration (if required)

Issues Fixed or Closed

• Fixes Sonarr for anime only - remove requirement #2876

[thempc]

This is my first time contributing here, so I'm sure there's something I've done wrong :) please let me know.
I've also just done this based on both my own needs and seemingly the needs of others (looking at the multiple tickets + threads on Discord)

[Feramance]

Please make this so

[thempc]

I've noticed that with the current pull request any Anime requests will not fallback to the regular default service instance if there is no default anime service. Making this a breaking change. I think it would be better if this wasn't a breaking change so I will update this with a small ammentmend to make it have a fallback.

[thempc]

Validated this does now correctly use fallbacks. When requesting anime with just a single default server without changing any settings related to this change, Overseerr will send the request to the default instance. When afterwards setting up another Sonarr instance with the Anime default flag enabled, it routes the requests there instead.

[Feramance]

Might I suggest a slight change to mark the anime settings as required, and normal settings as not required in the event that it is an anime instance?

[thempc]

Might I suggest a slight change to mark the anime settings as required, and normal settings as not required in the event that it is an anime instance?

I unfortunately don't understand the suggestion. If you could elaborate that would be great.

[Feramance]

Might I suggest a slight change to mark the anime settings as required, and normal settings as not required in the event that it is an anime instance?

I unfortunately don't understand the suggestion. If you could elaborate that would be great.

As you can see below, the asterisks are denoting the fields are required. Now when setting up an anime server, I imagine that its not the general quality/root folder you are using, but the anime quality/root folder. Therefore is it possible to have the required quality/root folder fields for anime be set to required, while the general ones set to not required when the isAnime tick box is ticked?

[thempc]

@Feramance as requested, the previous commit marks the Anime-specific dropdown as required. It however does not mark the normal ones as not required. This is because I couldn't find a logical flow in which those could be optional.

[OwsleyJr]

@Feramance as requested, the previous commit marks the Anime-specific dropdown as required. It however does not mark the normal ones as not required. This is because I couldn't find a logical flow in which those could be optional.

Not sure how I feel about having two options for profile, folder, etc. when this is for an anime specific Sonarr. The flow would either need to be modified to remove/hide one of them or just completely disable a set of options.

[thempc]

Hmmm, well I can understand that hiding it would be better. So, I would like to suggest the following scenarios:

• A user has one server, marked as a regular default server (nothing changes, it accepts both TV and Anime)
• A user has two servers, one marked regular default and one anime default (here we change the anime interface to hide the regular TV options)
• A user has one server, marked as default anime (show only the anime settings, and display an error that there is no regular default server)

This should keep backwards compatibility and give the UI a cleaner look. If this is acceptable I will implement this.

[Feramance]

Hmmm, well I can understand that hiding it would be better. So, I would like to suggest the following scenarios:

• A user has one server, marked as a regular default server (nothing changes, it accepts both TV and Anime)
• A user has two servers, one marked regular default and one anime default (here we change the anime interface to hide the regular TV options)
• A user has one server, marked as default anime (show only the anime settings, and display an error that there is no regular default server)

This should keep backwards compatibility and give the UI a cleaner look. If this is acceptable I will implement this.

I do have one other suggestion, though a little extra, it should make everything cleaner.

• Add another tick box labeled Series
• Default Sonarr service will show fields for both Series and Anime
• If Series is selected then only the fields for general series are shown
• if Anime is selected then only the fields for anime are shown

This both keeps backwards compatibility and more granular control on what service handles what

[thempc]

I'm fine with either of the above, @OwsleyJr if you could pass your verdict on whichever you prefer, I'll make it so :)

[OwsleyJr]

I'm fine with either of the above, @OwsleyJr if you could pass your verdict on whichever you prefer, I'll make it so :)

We might need further input from @sct before going ahead due to this being a big change in the flow.

[thempc]

It's been about a month at this point. Please decide to accept this or not. If it's not wanted that's fine but I'm not one to keep going after open source changes months after a pull request has been made.

[Quack6765]

Any update regarding this ? I would love to have this feature so that I can get rid of my other overseerr instance just for anime and stop people from mixing instances and requesting anime on the tv instance or the opposite.

[nrlcode]

+1 as well. I've been using the current build and it works great, would really like to see this fully implemented so I don't need to run my own custom version and get get future updates more easily.

[Feramance]

@sct Any feedback?

[Feramance]

I'm fine with either of the above, @OwsleyJr if you could pass your verdict on whichever you prefer, I'll make it so :)

We might need further input from @sct before going ahead due to this being a big change in the flow.

Is it possible to have a new docker tag with this PR change installed? At least until @sct responds

[solidsnakex37]

I'm fine with either of the above, @OwsleyJr if you could pass your verdict on whichever you prefer, I'll make it so :)

We might need further input from @sct before going ahead due to this being a big change in the flow.

Is it possible to have a new docker tag with this PR change installed? At least until @sct responds

Please?

[thempc]

I'm fine with either of the above, @OwsleyJr if you could pass your verdict on whichever you prefer, I'll make it so :)

We might need further input from @sct before going ahead due to this being a big change in the flow.

Is it possible to have a new docker tag with this PR change installed? At least until @sct responds

Please?

Who's task would this be to arrange this temporarily? I'm unfamiliar with Docker packages, but I can try to set it up.

[Vankerkom]

Hey, @OwsleyJr, @sct , it seems that a few people are eagerly awaiting this feature.
Is there a way to get this approved in the near future?

[thempc]

Continuing conversation of #2876 (comment) here, as it's related to the PR. I will investigate why this doesn't work with requestrr, I personally only use the WebUI so that was my test case.

[thempc]

@Infray can you share how you've setup your services in Overseerr? Or ping me in the Overseerr Discord, that's likely easier.

[thempc]

I tested this with Requestrr, seems to request fine, however it doesn't make a distinction between TV shows and anime from the request side, so everything goes to the TV show Sonarr service. I guess it would be up to Requestrr to support requesting anime, or for Overseerr to get the TVDB data on external API requests to determine what kind of request it is.

[Feramance]

Or a change in the API processing to check the tags for the requested show

[Plancke]

I've been running a custom build with this for a while and besides this PR for movie collections I haven't run into any issues,

As the description of the PR says though, my modal doesn't seem to have the overrides, and they seem to default to the wrong thing under the hood (normal default instance) so I wasn't sure how to handle that best. Hence why they're just commented out for now.

[Infray]

I tested this with Requestrr, seems to request fine, however it doesn't make a distinction between TV shows and anime from the request side, so everything goes to the TV show Sonarr service. I guess it would be up to Requestrr to support requesting anime, or for Overseerr to get the TVDB data on external API requests to determine what kind of request it is.

Apologies, I lost track of this thread due to real life.
@thempc Thanks for looking into this. Doesn't sound like an easy fix.
I'll wait till official support is added, until then your branch is running great for me