Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use metric_kwargs in check_array_api_metric_pairwise #29045

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix use metric_kwargs in check_array_api_metric_pairwise #29045

merged 1 commit into from
May 20, 2024

Conversation

EdAbati
Copy link
Contributor

@EdAbati EdAbati commented May 18, 2024

What does this implement/fix? Explain your changes.

As discussed here, we need to pass metrics_kwargs when using the check_array_api_metric_pairwise.

cc @OmarManzoor @betatim

@EdAbati EdAbati mentioned this pull request May 18, 2024
Merged
@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 1322eea. Link to the linter CI: here

OmarManzoor
OmarManzoor approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting this @EdAbati

@OmarManzoor OmarManzoor merged commit 3a023b0 into scikit-learn:main May 20, 2024
33 of 34 checks passed
@EdAbati EdAbati deleted the fix-pairwise-test-metrics-kwargs branch May 20, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:metrics No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EdAbati @OmarManzoor