[path-] fix undercounted progress for multibyte chars #2407
+48
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjakefala
force-pushed
the
pw24_textprogress
branch
from
c4c49e4
to
28b16a8
Compare
|
Okay, I'll do some testing for loading speed. Profiling has become easier now that #2369 has made replay behavior faster and more consistent. Before that, the loading time for a large file (using replay) varied quite a bit, with a standard deviation of 2-5% of the mean loading time. Testing a change used to require a few dozen runs to detect a few percentage points of improvement in loading time, which took about a half hour. After #2369, the standard deviation is 0.5-1%, and the individual runs are 30-80% faster on my system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried moving all the functionality from #2323 into a TextProgress class to keep it out of the path.py, and I simplified it some as I didn't want to join all the lines together. This probably regresses some performance issues that @midichef had already addressed; let's call out the perf cases we should test with. Ideally they could become part of a build load/save perf report.