Allow custom accept-then keybindings from edit mode #2193
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow a mapping in the form "keystroke -> iterable-of-vd-functions" to
define custom keybindings that accept input and then queue one or more
vd functions. With these changes, an option like the following can
define custom "accept/move/re-edit" flows:
vd.options.edit_accept_keybindings = {
"Ctrl+N": ("go-down", "edit-cell"),
"Ctrl+P": ("go-up", "edit-cell"),
}
saulpw
reviewed
Feb 23, 2024
| @@ -623,6 +625,7 @@ def editCell(self, vcolidx=None, rowidx=None, value=None, **kwargs): | |||
|
|
|||
| # update local bindings with kwargs.bindings instead of the inverse, to preserve kwargs.bindings for caller | |||
| bindings.update(kwargs.get('bindings', {})) | |||
| bindings.update({k: acceptThenFunc(*v) for k, v in options.edit_accept_keybindings.items()}) | |||
There was a problem hiding this comment.
I like the idea of allowing people to customize their keybindings for edit/input, but the 'always accept' gives me pause every time I come back to it. I think it'd be better if we had user-set bindings apart from options, and required them to manually specify something like acceptThenFunc. Like:
vd.edit_bindings = {
'Ctrl+X': acceptThenFunc('syscopy-cell', 'delete-cell')
}
but that API is pretty terrible too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a mapping in the form "keystroke -> iterable-of-vd-functions" to define custom keybindings that accept input and then queue one or more vd functions. With these changes, an option like the following can define custom "accept/move/re-edit" flows: