-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(whisper): add request parameter TimeStampGranularities and respo… #673
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
=======================================
Coverage 98.44% 98.45%
=======================================
Files 24 24
Lines 1353 1361 +8
=======================================
+ Hits 1332 1340 +8
Misses 15 15
Partials 6 6 ☔ View full report in Codecov by Sentry. |
audio_test.go
Outdated
Temperature: 0.5, | ||
Language: "en", | ||
Format: AudioResponseFormatVerboseJSON, | ||
TimeStampGranularities: []TimestampGranularity{TimestampGranularityWord}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Could we please keep this as a separate test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a individual test TestAudioTimeGranularities
TimeStampGranularities []TimestampGranularity | ||
} | ||
|
||
type Word struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the name Word
is very generic, could we please either change it to something like AudioResponseWord
or make it anonymous similar to Segments []struct {
in AudioResponse
?
Describe the change
Add new struct field
timestamp_granularities[]
andwords
for whisper transcatiption APIProvide OpenAI documentation link
Describe your solution
Add OpenAI new added parameter in request&response
Tests
manual