Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10382 - Fix issue with enum keys being used when setting values #10383

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

JackBuchanan
Copy link
Contributor

Update how enums fields are handled when setting workflow values

Description

Add extra case to switch statement to handle enums
When a varchar is being set to the value of an enum use the enum label
When a enum is being set to the value of an enum use the enum key

Motivation and Context

Fixes issue with varchars being set with enum key values

How To Test This

See #10382

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

…ting values

Update how enums fields are handled when setting workflow values
@serhiisamko091184
Copy link
Contributor

Hi @JackBuchanan,

Thanks for your PR!

Regards,
Serhii

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix PR 4-8 Score given to PRs once assessed labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants