Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7150 - Show subpanels correctly #10380

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from
Open

Fix #7150 - Show subpanels correctly #10380

wants to merge 1 commit into from

Conversation

ebogaard
Copy link

Description

Fixes the wrong layout of several subpanels in the Campaign-module.
Change based on the code of the default "SubPanelViewer.php".

Motivation and Context

How To Test This

Open a Campaign in DetailView and check the subpanel layout.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SuiteBot
Copy link

SuiteBot commented Mar 18, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Area: Campaigns Issues & PRs related to all things regarding campaigns Branch:Hotfix PR 4-8 Score given to PRs once assessed labels Mar 19, 2024
@serhiisamko091184
Copy link
Contributor

Hello @ebogaard,

thanks for the contribution to the SuiteCRM project!

Regards,
Serhii

@jack7anderson7 jack7anderson7 added Status: Requires Testing Requires Manual Testing Status: Passed Code Review Mark issue has passed code review reviewed and removed Status: Requires Code Review Needs the core team to code review labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack7anderson7 jack7anderson7 jack7anderson7 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area: Campaigns Issues & PRs related to all things regarding campaigns Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Requires Testing Requires Manual Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ebogaard @SuiteBot @serhiisamko091184 @jack7anderson7