Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unassign shipping address on CheckoutDeliveryMethodUpdate from C&C #16006

Merged

Conversation

tomaszszymanski129
Copy link
Member

I want to merge this change because it fixes behavior of C&C with checkoutShippingMethodUpdate.

  • Switching to a collection point with WarehouseClickAndCollectOption.DISABLED is now forbidden and will raise ValidationError.
  • Switching from C&C to a standard delivery method now removes the shipping address from the checkout (it used to stay with the warehouse address).
  • Switching the delivery method to none (without passing deliveryMethodId) now removes the checkout address if there was C&C previously selected.
  • Switching from C&C LOCAL_STOCK to ALL_WAREHOUSES now works - shipping address updates to the new collection point.
  • Warehouse is now validated by the variants from checkout.

more context: https://linear.app/saleor/issue/SHOPX-568/switching-from-clickandcollect-to-shipping-automatically-pre-fills-the

Docs PR: saleor/saleor-docs#1153

⚠️ This is a port of #15975

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Docs

  • Link to documentation:

Pull Request Checklist

  • Privileged queries and mutations are either absent or guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migrations are either absent or optimized for zero downtime
  • The changes are covered by test cases
  • All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
  • All migrations have proper dependencies
  • All indexes are added concurrently in migrations
  • All RunSql and RunPython migrations have revert option defined

@db-queries
Copy link

db-queries bot commented May 16, 2024

Here is the report for a1dcc4a (saleor:SHOPX-568-shipping-method-update-clean-cc-address-316)
Missing base report (bcb7bfa). The results couldn't be compared.

No differences were found.

@tomaszszymanski129 tomaszszymanski129 requested a review from a team May 16, 2024 12:44
@IKarbowiak IKarbowiak requested a review from a team May 16, 2024 13:33
@tomaszszymanski129 tomaszszymanski129 merged commit c638b34 into 3.16 May 17, 2024
10 checks passed
@tomaszszymanski129 tomaszszymanski129 deleted the SHOPX-568-shipping-method-update-clean-cc-address-316 branch May 17, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants