Bug/12308 #15781
Bug/12308 #15781
Conversation
|
Hi @moraj-turing, thank you for your contribution! About changes, please adjust PR name to something more meaningful (e.g. the issue name). Is this PR ready for review? Cause from my understanding it's still missing some of the requirements from the ticket. You can always mark PR as draft when you still working on it, and this way it will be more clear for other developers. |
|
Hello, this PR is ready. Most of the work was already done on previous changes by other contributors. |
There was a problem hiding this comment.
And couple more general comments:
- please install
pre-commitlocally to run checks. More can be read here: https://docs.saleor.io/docs/3.x/developer/community/contributing#coding-style - above will run check that graphql schema changes are not included, to generate schema you can ran
npm run build-schema - please update
CHANGELOG.mdfile - I don't see changes regarding firing the webhook, will that be included?
| class Meta: | ||
| doc_category = DOC_CATEGORY_PRODUCTS | ||
|
|
||
|
|
||
| class ProductMediaCreate(BaseMutation): | ||
| product = graphene.Field(Product) | ||
| media = graphene.Field(ProductMedia) | ||
| support_meta_field = True |
There was a problem hiding this comment.
Can you please add tests to check ensure that changes works?
| @@ -939,6 +939,7 @@ class Product(ChannelContextTypeWithMetadata[models.Product]): | |||
| ) | |||
| variants = NonNullList( | |||
| ProductVariant, | |||
| required=True, | |||
There was a problem hiding this comment.
Please do not mix different issues together in one PR
This PR implements missing requirements from #12308
Impact
Docs
N/A
Pull Request Checklist
ADDED_IN_X,PREVIEW_FEATURE, etc.)