Resolve Issue #2282 #2280 Fix Column Permission Issues: Unchecking All Options and Substring Filtering #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oles to see all fields. 2. Address the issue where using the 'contains' method for column permissions leads to sub-strings not being filtered out. Switch to using regular expression for a more accurate permission check.
fuchanghai
suggested changes
Jan 10, 2024
| @@ -214,7 +215,8 @@ private void excludeColumns(Dataframe data, Set<SelectColumn> include) { | |||
| .noneMatch(selectColumn -> | |||
| column.columnKey().equals(selectColumn.getColumnKey()) | |||
| || column.columnKey().equals(selectColumn.getAlias()) | |||
| || column.columnKey().contains(selectColumn.getColumnKey()))) { | |||
| // 用正则做聚合函数权限的判断 剔除原来的contains判断 | |||
There was a problem hiding this comment.
ok i will change to use english
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve Issue
#2282
#2280