Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bedrock support added, only for Anthropic models #847

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

parhammmm
Copy link
Contributor

@parhammmm parhammmm commented May 16, 2024

Only Anthropic is supported but others can be added by adding a Provider class

Usage (using api keys - there are other methods):

  const bedrock = new Bedrock({
    model: BEDROCK_MODELS.ANTHROPIC_CLAUDE_3_HAIKU,
    region: "us-east-1",
    credentials: {
      accessKeyId: "...",
      secretAccessKey: "...",
    },
  });

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 9133cf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
docs Patch
@llamaindex/community Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llama-index-ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 4:35pm

Copy link
Member

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move to @llamaindex/experimental or @llamaindex/community, since I'm not sure if this is stable

@parhammmm
Copy link
Contributor Author

Could we move to @llamaindex/experimental or @llamaindex/community, since I'm not sure if this is stable

@himself65 sure I can move it.

Which part is concerning maybe I can take a look?

@parhammmm parhammmm force-pushed the feature-aws-bedrock-anthropic branch from 54d0acc to 831e4cc Compare May 23, 2024 17:18
@parhammmm
Copy link
Contributor Author

Could we move to @llamaindex/experimental or @llamaindex/community, since I'm not sure if this is stable

Done! I moved it to @llamaindex/community, is it's publishing to npm automatic?

@parhammmm
Copy link
Contributor Author

parhammmm commented May 27, 2024

@himself65 @marcusschiesser what do you guys think? let me know if any futher changes are needed. Just waiting on this to then make the agents for bedrock too, since this #881 has been quite effective

@petergoldstein
Copy link
Contributor

@himself65 @marcusschiesser We'd really like to see this land. I think @parhammmm has done everything that was requested. Is there any additional work required to get this merged? Thanks!

@himself65
Copy link
Member

Sorry for the late response, I was on vacation. This is LGTM, let me do some small change

@himself65 himself65 merged commit 8832669 into run-llama:main Jun 3, 2024
14 of 15 checks passed
@parhammmm
Copy link
Contributor Author

@himself65 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants