-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: router processing error #4687
Conversation
Important Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4687 +/- ##
=======================================
Coverage 74.47% 74.48%
=======================================
Files 413 412 -1
Lines 48752 48699 -53
=======================================
- Hits 36310 36274 -36
+ Misses 10056 10047 -9
+ Partials 2386 2378 -8 ☔ View full report in Codecov by Sentry. |
r.backgroundGroup = g | ||
if err := r.uploadRepo.ResetInProgress(ctx, r.destType); err != nil { | ||
return err | ||
} | ||
g.Go(misc.WithBugsnagForWarehouse(func() error { | ||
r.backendConfigSubscriber(ctx) | ||
r.backendConfigSubscriber(gCtx) | ||
return nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could potentially return gCtx.Err()
in the routines that return nil
.
071f213
to
47ac400
Compare
47ac400
to
305e641
Compare
06f5165
to
7268efe
Compare
Description
Security