Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RadioGroup): fix radio can't reselect #2447

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarvelSQ
Copy link
Member

CHANGES

remove defaultChecked. make radio fully controlled by rsuite state.

ISSUE

close #2446

@vercel
Copy link

vercel bot commented Apr 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rsuite-v4 – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-v4/9VahELgmJiRBMhvZEzC6JyNRRbXt
✅ Preview: Ignored

rsuite-nextjs – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-nextjs/BRCSYRgfQUUvgo5WSqXGUzrv1DkT
✅ Preview: https://rsuite-nextjs-git-fix-radio-reselect-rsuite.vercel.app

@MarvelSQ MarvelSQ requested a review from simonguo April 13, 2022 07:18
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cfb9b1c:

Sandbox Source
rsuite-tp-ci Configuration
peaceful-tree-hlpjor Issue #2446

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #2447 (cfb9b1c) into main (32c5c67) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2447      +/-   ##
==========================================
- Coverage   85.64%   85.63%   -0.01%     
==========================================
  Files         275      275              
  Lines        8657     8655       -2     
  Branches     2434     2432       -2     
==========================================
- Hits         7414     7412       -2     
  Misses        655      655              
  Partials      588      588              
Flag Coverage Δ
ChromeCi 85.63% <ø> (-0.01%) ⬇️
Firefox 85.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Radio/Radio.tsx 90.32% <ø> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c5c67...cfb9b1c. Read the comment docs.

Copy link
Member

@SevenOutman SevenOutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case or modify an existing test case to ensure the issue is fixed with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uncontorlled RadioGroup can't reselect radio
2 participants