-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add durable storage MVP #267
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MasterPtato and the rest of your teammates on Graphite |
f6e97b3
to
e4cabfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall!
I don't know too much about durable storage and the idea behind it, but I think the Deno implementation is pretty severely lacking without persistence.
Additionally, most of the comments I left on the Deno impl also apply to the CF impl.
Again, I apologize for advocating for more typescript complexity, but if instantiating a Durable
it isn't disallowed by the type system, we NEED to explicitly document that. Module authors will definitely do that by accident.
Additionally, I'm not completely sure what the "point" of the durable storage is. Is that not what postgres and prisma are for?
@MasterPtato would you rather me wait until the next iteration is ready to go or review this now? |
@Blckbrry-Pi @NathanFlurry this was meant to be a draft sorry |
e4cabfa
to
c6d5e6e
Compare
c6d5e6e
to
4ff9bac
Compare
4ff9bac
to
832f88c
Compare
832f88c
to
ec33168
Compare
@MasterPtato merging this since it's blocking other things. let's make sure this gets cleaned up at some point soon. |
Merge activity
|
ec33168
to
75fd0dc
Compare
Resolves OGBE-97