Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR - External Contributors Testing #1832

Closed
wants to merge 65 commits into from

Conversation

RDaneelOlivaw0
Copy link

No description provided.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
docs-website ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 8:46pm
reports-and-benchmarks ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 8:46pm

Copy link

vercel bot commented May 14, 2024

Someone is attempting to deploy a commit to the RISC Zero Team on Vercel.

A member of the Team first needs to authorize it.

@SchmErik
Copy link
Contributor

Hi @RDaneelOlivaw0, what are you trying to test specifically?

@flaub
Copy link
Member

flaub commented May 16, 2024

That 3rd-party contributors can run builds

…ing install and run for macOS / update IAM_RA_PATH for executing signing tool to configure creds
- name: (External PR) Install AWS Signer (macOS)
if: >
runner.os == 'macOS' &&
github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name &&
runner.environment == 'self-hosted'
env:
DARWIN_SIGNER_URL: https://rolesanywhere.amazonaws.com/releases/1.1.1/X86_64/Darwin/aws_signing_helper
IAM_RA_PATH: ../../_aws
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should avoid using relative paths. Let's just assume this tool is installed in a well known location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants