-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix send_recv_slice when U != u8 #1620
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
@hashcashier did this fix your issue? |
Is there a test we can write which shows the issue? |
friendly ping! @hashcashier could you answer this question? |
superseded by: #1874 |
send_recv_slice
, which is used to allow the host to define "custom syscalls" has a bug which means that it only works when the generic typeU
isu8
. This is because the host returns to the guest a length for how many bytes it will send to the guest on the next call. The guest code currently interprets this number of bytes to be a number of elements of typeU
. So whenmem::size_of::<U> != 1
, the length will be incorrect and the second read will fail.