-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimeDimensionDisplay DST day conversion fix #3819
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
) { | ||
return original?.map((originalPt, i) => { | ||
const comparisonPt = comparison?.[i]; | ||
|
||
const ts = adjustOffsetForZone(originalPt.ts, zone); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the charts, we need to have this offset. Javascript assumes the dates are in the user's timezone. We need to account for that across our charts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you elaborate what is broken in the screenshot?
@egor-ryashin @djbarnwal @AdityaHegde Do we have an update on this bug fix? I believe it's still an outstanding issue. |
The issue is more complex than I expected @djbarnwal is going to take a look |
@djbarnwal I wonder if there're any updates? |
Checklist
Summary
Issue addressed:
#3560 (comment)
Details:
Steps to Verify
first_day_of_week: 7
America/New_York
Timezone ID.