Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logging)!: drop logFile and logFileLevel #29104

Merged

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented May 15, 2024

Changes

  • Drop logFile and logFileLevel

Context

Closes: #14705

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/config/validation.ts Outdated Show resolved Hide resolved
RahulGautamSingh and others added 2 commits May 16, 2024 22:53
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you got all references to the things you're removing?

The Jest test description is good now. 😄

As usual, I'll let a maintainer do the full review.

@RahulGautamSingh
Copy link
Collaborator Author

Are you sure you got all references to the things you're removing?

Yes. 🤗

@rarkins rarkins changed the title feat(logging): drop logFile and logFileLevel feat(logging)!: drop logFile and logFileLevel May 17, 2024
@rarkins rarkins merged commit e79e78e into renovatebot:v38 May 17, 2024
34 checks passed
rarkins pushed a commit that referenced this pull request May 19, 2024
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
rarkins pushed a commit that referenced this pull request May 31, 2024
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants