Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling the placeholder #1994

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeffrafter
Copy link

@jeffrafter jeffrafter commented Feb 11, 2023

Summary

When at least two users are collaborating (for example using the WebrtcProvider) and a user selects all and deletes the document becomes empty. This triggers the PlaceholderExtension which creates a decoration node for the placeholder message. Typing (collaborative) becomes disabled in the editing user window until they hit enter. This is because the node position / selection is confused and YJS can't sync.

This allows you to disable the decorations in the placeholder. In general, I feel like this approach solves the issue (which is why I've opened this PR) but doesn't feel ergonomic. It would be better to remove the extension altogether in this case. An example of how that might be done is here: 9738b2c

Fixes #1993

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2023

⚠️ No Changeset found

Latest commit: 0283db0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the framework: react ⚛️ Any changes to packages which are exclusively used for react code bases. label Feb 11, 2023
@andrew-maltsev
Copy link

hey any updates? this is really crucial bugfix for collaborating on mobile and desktop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: react ⚛️ Any changes to packages which are exclusively used for react code bases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YJS Extension editing interrupted by PlaceholderExtension decorations when collaborating
2 participants