Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When at least two users are collaborating (for example using the
WebrtcProvider
) and a user selects all and deletes the document becomesempty
. This triggers thePlaceholderExtension
which creates a decoration node for the placeholder message. Typing (collaborative) becomes disabled in the editing user window until they hitenter
. This is because the node position / selection is confused and YJS can't sync.This allows you to disable the decorations in the placeholder. In general, I feel like this approach solves the issue (which is why I've opened this PR) but doesn't feel ergonomic. It would be better to remove the extension altogether in this case. An example of how that might be done is here: 9738b2c
Fixes #1993