-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Port window-scroll-bars #1538
base: master
Are you sure you want to change the base?
Conversation
} else { | ||
None | ||
}; | ||
list!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did the original use Fcons
instead of list6()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that they only have up to list5
:
Lines 3706 to 3711 in fb2e5d7
extern Lisp_Object list1 (Lisp_Object); | |
extern Lisp_Object list2 (Lisp_Object, Lisp_Object); | |
extern Lisp_Object list3 (Lisp_Object, Lisp_Object, Lisp_Object); | |
extern Lisp_Object list4 (Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object); | |
extern Lisp_Object list5 (Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, | |
Lisp_Object); |
With list!
, I think the rust version really shines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. list!
is so much nicer. I suspected that was the answer about list5, but I did not have the chance to check.
What is left to complete for this PR? |
This PR ports
window-scroll-bars
. I still need to add some ert tests, though.