Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-example #3324

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update docker-example #3324

wants to merge 2 commits into from

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented May 16, 2024

Improvements:

  • use exec when starting reflex to make it PID 1 in the container
  • include redis-server in the simple containers for better concurrency

Create 4 separate examples with separate README files for different use cases:

  • simple-two-port: this is the same as the previous Dockerfile, except with redis
  • simple-one-port: this is the same as app.Dockerfile, but with the Caddyfile pulled out and redis included
  • production-compose: for deployment on a standalone VPS
  • production-app-platform: for deployment on AWS, Azure, GCE, etc. This deployment expects the frontend, redis, and database to be managed separately depending on the platform.

Improvements:

  * use `exec` when starting `reflex` to make it PID 1 in the container
  * include `redis-server` in the simple containers for better concurrency

Create 4 separate examples with separate README files for different use cases:

* simple-two-port: this is the same as the previous Dockerfile, except with redis
* simple-one-port: this is the same as app.Dockerfile, but with the Caddyfile
  pulled out and redis included
* production-compose: for deployment on a standalone VPS
* production-app-platform: for deployment on AWS, Azure, GCE, etc. This
  deployment expects the frontend, redis, and database to be managed separately
  depending on the platform.
@@ -1,5 +1,8 @@
# This Dockerfile is used to deploy a simple single-container Reflex app instance.
FROM python:3.11
FROM python:3.12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others seems to use 3.11, why 3.12 for this one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants