Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove hardcoded path prefix from remix bin command #5948

Merged
merged 1 commit into from
May 21, 2024

Conversation

BatuhanW
Copy link
Member

@BatuhanW BatuhanW commented May 15, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

What is the new behavior?

fixes # (issue)

Notes for reviewers

@BatuhanW BatuhanW requested a review from a team as a code owner May 15, 2024 08:01
Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: fd05a0d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BatuhanW BatuhanW added this to the June Release milestone May 15, 2024
@BatuhanW BatuhanW changed the title fix(cli): remove hardcoded path prefix from bin resolve for remix run… fix(cli): remove hardcoded path prefix from remix bin command May 15, 2024
Copy link

nx-cloud bot commented May 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fd05a0d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 75 targets

Sent with 💌 from NxCloud.

Copy link

cypress bot commented May 15, 2024

Passing run #11084 ↗︎

0 378 33 0 Flakiness 0

Details:

Merge fd05a0d into 7fadea9...
Project: refine Commit: 27f21410ef ℹ️
Status: Passed Duration: 25:14 💡
Started: May 15, 2024 8:09 AM Ended: May 15, 2024 8:34 AM

Review all test suite changes for PR #5948 ↗︎

@BatuhanW BatuhanW merged commit d5af7bf into releases/june May 21, 2024
92 checks passed
@BatuhanW BatuhanW deleted the fix-cli-remix-bin-path branch May 21, 2024 10:55
@aliemir aliemir mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants