cst: Change acceptable query miss condition #18574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a query for an offset misses, it is possible that this happens because the manifest was entirely truncated. Truncation usually happens in two steps, first the start offset is advanced and later on the manifest segments are removed. If the query falls between these two steps, the current condition to accept a query miss as a non-error may fail, because it uses the kafka log start offset. If the manifest start offset has been advanced beyond the entire manifest span, the kafka offset is now not calculatable, which results in nullopt kafka start, which does not match the condtion and the query miss is recorded as an error. The change detects the condition where the manifest is fully truncated and the query offset lies within truncated range, if so the query is considered not to have failed.
|
Looking at the merge conflict, the changes in this PR go against the changes in #18097 in terms of introducing lenience when accepting errors, specifically d1543ee Since the changes in #18097 move towards making the behavior of |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a query for an offset misses, it is possible that this happens because the manifest was entirely truncated. Truncation usually happens in two steps, first the start offset is advanced and later on the manifest segments are removed.
If the query falls between these two steps, the current condition to accept a query miss as a non-error may fail, because it uses the kafka log start offset. If the manifest start offset has been advanced beyond the entire manifest span, the kafka offset is now not calculatable, which results in nullopt kafka start, which does not match the condtion and the query miss is recorded as an error.
The change detects the condition where the manifest is fully truncated and the query offset lies within truncated range, if so the query is considered not to have failed.
FIXES #18454
Backports Required
Release Notes