Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HPEXPIRE, HPEXPIREAT, HPEXPIRETIME, HTTL and HPTTL #2857

Merged
merged 12 commits into from
May 22, 2024

Conversation

tishun
Copy link
Collaborator

@tishun tishun commented May 17, 2024

As part of #2834

Implement HPEXPIRE, HPEXPIREAT, HPEXPIRETIME, HTTL and HPTTL

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@tishun tishun self-assigned this May 17, 2024
@tishun tishun added the type: enhancement A general enhancement label May 17, 2024
@tishun tishun added this to the 7.x milestone May 17, 2024
@mp911de
Copy link
Collaborator

mp911de commented May 22, 2024

Nit: Comments of HPERSIST contain {@List} of {@Long} instead of {@link List} of {@code long}.

Copy link
Collaborator

@atakavci atakavci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tishun
Copy link
Collaborator Author

tishun commented May 22, 2024

Nit: Comments of HPERSIST contain {@List} of {@Long} instead of {@link List} of {@code long}.

Good catch, was meaning to change that, will address it along the other things we talked about

@tishun tishun merged commit 27dbd4b into redis:main May 22, 2024
4 checks passed
@tishun tishun deleted the topic/tishun/issue-2834-2 branch May 22, 2024 13:01
@tishun tishun modified the milestones: 7.x, 7.0.0.RELEASE Jun 6, 2024
@tishun tishun added this to the 6.4.0.RELEASE milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants