Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Event-Publisher Flush Queue on Shutdown (#767)" #793

Open
wants to merge 2 commits into
base: v2.5-unsupported-gcp
Choose a base branch
from

Conversation

seanrees
Copy link

This reverts commit 62da77f.

See #789 and internally, DE-5663.

💸 TL;DR

This reverts the above commit because of erroneous BatchFull exception. This branch had changes on top and required a manual revert.

🧪 Testing Steps / Validation

% docker-compose run -i --build --rm baseplate make test

✅ Checks

  • [✅ ] CI tests (if present) are passing
  • [✅ ] Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@seanrees seanrees requested a review from a team as a code owner May 17, 2023 11:46
@seanrees seanrees requested review from KTAtkinson and maeivysea and removed request for a team May 17, 2023 11:46
@seanrees
Copy link
Author

Hey @KTAtkinson -- what's the merge process here like? I don't have powers myself to do so.

@chriskuehl
Copy link
Member

chriskuehl commented Apr 30, 2024

Removing the 2.7 label since it looks like this was already merged into the develop branch in #789 and was already released in new versions.

@seanrees do you still need this merged into the v2.5-unsupported-gcp branch? I know this has been sitting around for a while at this point.

@chriskuehl chriskuehl removed the v2.7 label Apr 30, 2024
@chriskuehl chriskuehl removed their request for review April 30, 2024 19:54
@seanrees
Copy link
Author

seanrees commented May 1, 2024

Thanks for following-up @chriskuehl. I'd vote to merge it just so we have the branch at the intended state -- but it's not a big deal either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants