Requests now use EffectId(u32) instead of Uuid
#238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charypar
approved these changes
May 17, 2024
| @@ -41,3 +41,4 @@ serde = { version = "1.0.201", features = ["derive"] } | |||
| static_assertions = "1.1" | |||
| rand = "0.8" | |||
| url = "2.5.0" | |||
| uuid = { version = "1.8.0", features = ["v4", "serde"] } | |||
There was a problem hiding this comment.
Is it still needed for dev...? 👀
There was a problem hiding this comment.
Not really. There's a test for sending UUID across the typegen IIRC. Could use another type though
obmarg
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EffectId(u32)Note, this does not affect Rust shells that use the core directly, as they bypass the bridge and the registry.
Also, we need to measure the performance of the slab (vs the HashMap we were using beforehand).
Incidentally, we now remove the slab entry once the effect is fully resolved (although subscription style callbacks, e.g. Server Sent Events, still keep the entry in case there are more resolutions. We need to look at how to signal the end of a subscription so these can be cleaned up too). Before this change all effects were "leaking", now its only the effects that can be resolved repeatedly).